Fix app sys id

Knuckles-Team · May 24, 2024 · a49d692 · a49d692
1 parent 55ae268
commit a49d692
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/servicenow_api/servicenow_api.py b/servicenow_api/servicenow_api.py
@@ -397,7 +397,7 @@ def app_repo_install(self, **kwargs) -> Union[Response, requests.Response]:
         :raises ParameterError: If auto_upgrade_base_app is not a boolean.
         """
         cicd = CICDModel(**kwargs)
-        if cicd.app_sys_id is None and cicd.scope is None:
+        if cicd.sys_id is None and cicd.scope is None:
             raise MissingParameterError
         try:
             response = self._session.post(
@@ -432,7 +432,7 @@ def app_repo_publish(self, **kwargs) -> Union[Response, requests.Response]:
         :raises MissingParameterError: If app_sys_id or scope is not provided.
         """
         cicd = CICDModel(**kwargs)
-        if cicd.app_sys_id is None and cicd.scope is None:
+        if cicd.sys_id is None and cicd.scope is None:
             raise MissingParameterError
         try:
             response = self._session.post(
@@ -465,7 +465,7 @@ def app_repo_rollback(self, **kwargs) -> Union[Response, requests.Response]:
         :raises MissingParameterError: If app_sys_id, scope, or version is not provided.
         """
         cicd = CICDModel(**kwargs)
-        if cicd.app_sys_id is None and cicd.scope is None or cicd.version is None:
+        if cicd.sys_id is None and cicd.scope is None or cicd.version is None:
             raise MissingParameterError
         try:
             response = self._session.post(

diff --git a/servicenow_api/servicenow_models.py b/servicenow_api/servicenow_models.py
@@ -322,7 +322,7 @@ def build_api_parameters(cls, values):
         if "target_sys_id" in values:
             filters.append(f'target_sys_id={values["target_sys_id"]}')
         if "app_sys_id" in values:
-            filters.append(f'sys_id={values["app_sys_id"]}')
+            filters.append(f'app_sys_id={values["app_sys_id"]}')
         if "branch_name" in values:
             filters.append(f'branch_name={values["branch_name"]}')
         if "credential_sys_id" in values: