Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support APNS with Token Authentication #62

Open
JanC opened this issue Nov 14, 2016 · 6 comments
Open

Support APNS with Token Authentication #62

JanC opened this issue Nov 14, 2016 · 6 comments
Labels
Milestone

Comments

@JanC
Copy link

JanC commented Nov 14, 2016

Hi,
Apple supports JWT token authentication and I was wondering if there is a plan to add this to the Knuff app. If no, what would be the contribution guidelines?

Reference:

cheers

@blommegard
Copy link
Member

Yes, this is very high up on my want-list for Knuff!
This fall have been crazy and the time haven't been here for Knuff. I will try to have a look at pull requests and merge/comment on them asap, so they are very welcoming!

@JanC
Copy link
Author

JanC commented Nov 14, 2016

ok great, I'll be happy to contribute as I use Knuff a lot. I'll create a PR if I have time to implement this

@blommegard blommegard added this to the 1.2 milestone Feb 4, 2017
@JanC
Copy link
Author

JanC commented Apr 29, 2017

Hi,
Just for the record, I started this ticket in the JWT library because it's something that will be needed for this feature.

yourkarma/JWT#116

@blommegard
Copy link
Member

@JanC What is the status of yourkarma/JWT#116 nowadays?

@JanC
Copy link
Author

JanC commented Sep 26, 2017

Funny that you ask because I was wondering that as well :)
I started to have a look at other solutions such as https://github.com/vapor/vapor-jwt

but it also does not work out of the box with Apple's keys apparently
vapor/jwt#47

@blommegard
Copy link
Member

https://github.com/ethanhuang13/CupertinoJWT seems to be the best alternative to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants