refactor(renderer): rewrite default renderer #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #64 +/- ##
=======================================
Coverage 84.21% 84.21%
=======================================
Files 3 3
Lines 19 19
Branches 3 3
=======================================
Hits 16 16
Misses 3 3Continue to review full report at Codecov.
|
Kocal
force-pushed
the
feat/default-render
branch
from
1d05c0a
to
07280fd
Compare
Kocal
added a commit
that referenced
this pull request
Jun 17, 2018
Kocal
pushed a commit
that referenced
this pull request
Aug 20, 2018
Bumps [cypress](https://github.com/cypress-io/cypress) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [cypress's releases](https://github.com/cypress-io/cypress/releases).* > ## 3.1.0 > *Released 8/13/2018* > > **Summary:** > > - Cypress can now run tests in parallel across multiple virtual machines, or can be parallelized on a single machine. Cypress will automatically figure out, detect, and load balance all of your specs in the fastest and most efficient way possible. There is no configuration other than passing a `--parallel` flag and spinning up multiple machines on your CI provider. From our experiments you can expect to see approximately 40% reduction in overall run time **per machine** you add. However, attempting to run in parallel on a single machine requires server grade hardware with dozens (or even hundreds) of CPU's and GB of RAM to run efficiently. A much better and simpler approach is to use a cluster of docker containers that are all isolated from each other. Any standard CI service (CircleCI, TravisCI, etc) comes with the ability to do this. We automatically tap into their environment variables to make parallelization possible without you having to configure anything. > - Beyond parallelization, you now have the ability to group multiple runs with each other so that they show up together (grouped) in the Dashboard. This enables you to test different applications, groups of specs, or different environments (like development, staging, production) and see all of the results together. We know how important cross browser testing is to everyone, so we built this to lead directly into aggregating the results of multiple browsers into a single run. > - The Dashboard Service has been updated to show you more visual information about what happened during a run. You can see how specs were parallelized and you can calculate the effect of adding or removing machines to help reduce the overall run time. > > **Features:** > > - `cypress run` accepts a new [`--parallel`](https://on.cypress.io/command-line#cypress-run-parallel) flag to run specs in parallel. Fixes [#1690](https://github-redirect.dependabot.com/cypress-io/cypress/issues/1690) and [#64](https://github-redirect.dependabot.com/cypress-io/cypress/issues/64) and [#2297](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2297). > - `cypress run` accepts a new [`--group`](https://on.cypress.io/command-line#cypress-run-group-lt-name-gt) flag to group multiple spec files within a single run. Fixes [#2169](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2169) > - `cypress run` accepts a new [--ci-build-id](https://on.cypress.io/command-line#cypress-run-ci-build-id-lt-id-gt) flag. Fixes [#2153](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2153). > > **Bugfixes:** > > - We've finally tracked down the source of specs "hanging" and failing to start when running Electron. We finally tracked it down to a bug in Electron itself with setting `menu` when using offscreen rendering. Fixes [#2322](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2322) and [#2294](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2294). > - Clicking on svg elements is now working. 3.0.2 introduced a bug that would throw an 'illegal invocation' error. Fixes [#2245](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2245) and [#2252](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2252) and [#2258](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2258) and [#2277](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2277) and [#2288](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2288). > - Fixed a regression in `3.0.2` that caused typing `{enter}` not to submit a form when there were `<button>` elements other than `type='submit'`. Fixes [#2261](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2261) and [#2326](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2326). > - Fixed a small visual bug where failed commands were not aligned to other commands. Fixes [#2314](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2314). > - Fixes a race condition where async electron browser commands came in after the renderer had been destroyed, causing failures. Fixes [#2321](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2321). > > **Misc** > > - When recording to the Dashboard Service, we now provide estimated durations per spec directly within the standard output, as long as the spec has had enough run history for this to be determined. Fixes [#2276](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2276). > - When using the new [`--parallel`](https://on.cypress.io/command-line#cypress-run-parallel) or [`--group`](https://on.cypress.io/command-line#cypress-run-group-lt-name-gt) feature, we now visually indicate that to you in the standard output when recording. Fixes [#2275](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2275). > - We have added support for more CI providers to automatically detect and show more relevant information in the Dashboard, instead of showing 'Unknown'. Fixes [#2146](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2146). > - We have added better checks and reliability for detecting runs in Jenkins. Fixes [#1990](https://github-redirect.dependabot.com/cypress-io/cypress/issues/1990). > - The built in [`cypress-browserify-preprocessor`](https://github.com/cypress-io/cypress-browserify-preprocessor) was bumped to `1.1.0`. This supports more JavaScript features by default, including async/await, object rest spread, and class properties. Fixes [#2254](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2254). > - [`cypress run`](https://on.cypress.io/command-line#cypress-run) now creates a new browser profile per run per browser, but keeps the same browser profile for interactive mode with [`cypress open`](https://on.cypress.io/command-line#cypress-open). This means you can run Cypress locally over multiple processes and the browser profiles will not conflict with each other. Fixes [#1566](https://github-redirect.dependabot.com/cypress-io/cypress/issues/1566). > - The Desktop-GUI has been updated to get the new routes provided by the Cypress API for runs. Fixes [#2189](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2189). > - Cypress now retries multiple times (with a backoff strategy) when communicating with our API fails while recording runs. This will provide better feedback in situations when the API is temporarily unavailable. Fixes [#1590](https://github-redirect.dependabot.com/cypress-io/cypress/issues/1590). > - When Cypress retries due to an API timeout or failure it now displays a very nice message indicating to you the delay and number of retries left. Fixes [#2280](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2280). > - We've added parallelization to our own internal tests for the driver and the desktop-gui. We've been able to reduce the number of concurrent instances our tests use by 4, and shaved about 6 minutes off of each build. Faster with less resources. Fixes [#2325](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2325). > > **Documentation Changes:** > > - [Added `Parallelization` doc.](https://on.cypress.io/parallelization) > - [Update `Dashboard Service` doc with new screenshots and run sections.](https://on.cypress.io/dashboard-service) > - [Update `Command Line` doc with new flags and alphabetized flags.](https://on.cypress.io/command-line) </details> <details> <summary>Commits</summary> - [`d48d842`](cypress-io/cypress@d48d842) release 3.1.0 [skip ci] - [`5732dab`](cypress-io/cypress@5732dab) add another e2e instance, move around some specs for balancing - [`47c0d67`](cypress-io/cypress@47c0d67) rename to squeeze out a bit more balanced perf (2) - [`fc7eb53`](cypress-io/cypress@fc7eb53) rename to squeeze out a bit more balanced perf - [`d6046ba`](cypress-io/cypress@d6046ba) use cypress parallelism, enable konfig process.env overrides, ([#2328](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2328)) - [`655162f`](cypress-io/cypress@655162f) fix failed command ui issue when pinned ([#2315](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2315)) - [`36760b8`](cypress-io/cypress@36760b8) Replace console.debug with console.log for logMemory ([#2317](https://github-redirect.dependabot.com/cypress-io/cypress/issues/2317)) - [`7139868`](cypress-io/cypress@7139868) call menu.set only in headed mode, defend against destroyed browser windows (... - [`60bc818`](cypress-io/cypress@60bc818) add debug + console.logs around setting the electron menu - [`916099f`](cypress-io/cypress@916099f) added lots more debug logs - Additional commits viewable in [compare view](cypress-io/cypress@v3.0.3...v3.1.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=cypress&package-manager=npm_and_yarn&previous-version=3.0.3&new-version=3.1.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> [//]: # (dependabot-start) ---⚠️ **Dependabot is rebasing this PR**⚠️ Sit tight and this PR will be updated for you in a minute. If you make any changes yourself then they'll take precedence over the rebase (which will be abandoned). [//]: # (dependabot-end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://htmlpreview.github.io/?https://github.com/Kocal/jsdoc-vuejs/blob/feat/default-render/example/docs/BetterCounter.html