Still retrieve git-version if using gitdir [no more ¯\_(ツ)_/¯] #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XANOZOID
changed the title
This was referenced Sep 8, 2021
|
There's a small style-issue to fix, would you do the honors? |
XANOZOID
force-pushed
the
findversionfix
branch
from
66c5192
to
875cbc8
Compare
Ahh, okay - taken care of! How can I check that on my side before submitting a pr, next time, if I may ask? |
|
Next time the GitHub-check will run automatically. To check it locally I use a tsline extension for vscode but you can also just run tsline manually. |
|
*tslint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support an alternative git structure that uses
gitdir:instead of a directory with git information.This fixes an issue, for me at least, where Khamake was only printing out
¯\_(ツ)_/¯for the version instead of the actual git version.I'm not sure if anything about git changed recently, but my project doesn't utilize git folders it just contains information in the .git file of where the relative git directory is.