fix(ignore): change pendingRequestTimeout quirk to checkinInterval (#…

…6884) Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Koenkk · Jan 13, 2024 · 35f962c · 35f962c
1 parent 5e58f2e
commit 35f962c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/src/devices/adeo.ts b/src/devices/adeo.ts
@@ -3,7 +3,7 @@ import * as exposes from '../lib/exposes';
 import fz from '../converters/fromZigbee';
 import * as reporting from '../lib/reporting';
 import tz from '../converters/toZigbee';
-import {electricityMeter, light, onOff, quirkPendingRequestTimeout} from '../lib/modernExtend';
+import {electricityMeter, light, onOff, quirkCheckinInterval} from '../lib/modernExtend';
 
 const e = exposes.presets;
 const ea = exposes.access;
@@ -276,7 +276,7 @@ const definitions: Definition[] = [
         toZigbee: [tz.warning],
         exposes: [e.warning(), e.battery(), e.battery_low(), e.tamper()],
         extend: [
-            quirkPendingRequestTimeout(0),
+            quirkCheckinInterval(0),
         ],
         configure: async (device, coordinatorEndpoint, logger) => {
             await device.getEndpoint(1).unbind('genPollCtrl', coordinatorEndpoint);

diff --git a/src/devices/bosch.ts b/src/devices/bosch.ts
@@ -1,4 +1,4 @@
-import {onOff, quirkPendingRequestTimeout} from '../lib/modernExtend';
+import {onOff, quirkCheckinInterval} from '../lib/modernExtend';
 import {Zcl} from 'zigbee-herdsman';
 import * as exposes from '../lib/exposes';
 import fz from '../converters/fromZigbee';
@@ -875,7 +875,7 @@ const definitions: Definition[] = [
             e.binary('ac_status', ea.STATE, true, false).withDescription('Is the device plugged in'),
         ],
         extend: [
-            quirkPendingRequestTimeout(0),
+            quirkCheckinInterval(0),
         ],
     },
     {

diff --git a/src/devices/xiaomi.ts b/src/devices/xiaomi.ts
@@ -9,7 +9,7 @@ import extend from '../lib/extend';
 import {
     light, numeric, binary, enumLookup, forceDeviceType,
     temperature, humidity, forcePowerSource, quirkAddEndpointCluster,
-    quirkPendingRequestTimeout,
+    quirkCheckinInterval,
 } from '../lib/modernExtend';
 const e = exposes.presets;
 const ea = exposes.access;
@@ -2946,7 +2946,7 @@ const definitions: Definition[] = [
         meta: {battery: {voltageToPercentage: '3V_2850_3000'}},
         exposes: [e.device_temperature(), e.battery(), e.battery_voltage()],
         extend: [
-            quirkPendingRequestTimeout('1_HOUR'),
+            quirkCheckinInterval('1_HOUR'),
             quirkAddEndpointCluster({
                 endpointID: 1,
                 inputClusters: [

diff --git a/src/lib/modernExtend.ts b/src/lib/modernExtend.ts
@@ -569,10 +569,9 @@ export function quirkAddEndpointCluster(args: QuirkAddEndpointClusterArgs): Mode
     return {configure, isModernExtend: true};
 }
 
-export function quirkPendingRequestTimeout(timeout: number | keyof typeof timeLookup): ModernExtend {
-    const timeoutMs: number = (typeof timeout == 'number') ? timeout : timeLookup[timeout] * 1000;
+export function quirkCheckinInterval(timeout: number | keyof typeof timeLookup): ModernExtend {
     const configure: Configure = async (device, coordinatorEndpoint, logger) => {
-        device.pendingRequestTimeout = timeoutMs;
+        device.checkinInterval = (typeof timeout == 'number') ? timeout : timeLookup[timeout];
         device.save();
     };