Add support for toggle command on Legrand 067774 #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With old firmwares supported actions on and off, while new firmwares only support action toggle. Added support for toggle and battery level
Koenkk
reviewed
Jul 27, 2021
| @@ -117,23 +117,23 @@ module.exports = [ | |||
| onEvent: readInitialBatteryState, | |||
| }, | |||
| { | |||
| zigbeeModel: [' Double gangs remote switch', 'Double gangs remote switch'], | |||
| zigbeeModel: [' Double gangs remote switch\u0000\u0000\u0000\u0000'], | |||
There was a problem hiding this comment.
Why has Double gangs remote switch been removed here?
There was a problem hiding this comment.
Because external converter doesn't work with it.
I think it's possible to use old variant, but i don't have device with old firmware version to check it.
Koenkk
reviewed
Jul 27, 2021
devices/legrand.js
Outdated
| model: '067774', | ||
| vendor: 'Legrand', | ||
| vendor: ' Legrand', |
There was a problem hiding this comment.
Please remove the trailing space.
There was a problem hiding this comment.
According to logs, that's the vendor name device send's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With old firmwares supported actions on and off, while new firmwares only support action toggle.
Added support for toggle and battery level
As described in #2841