MOSZB-140 : Add configurable occupancy endpoints #4731

sjorge · 2022-10-02T12:10:49Z

No description provided.

e.g. the MOSZB-140 has 35 as the default endpoint, most of the config on genBasic, genPowerCfg and ssIasZone are there. Additionally it uses seperate endpoints for temperature and illumance (40 and 39). It also has 3 (!!) msOccupancySensing endpoints (34, 40, 41), for those we do want to provide a suffix to the property name. For those we don't really need a suffix for the propery name, having `{default: 35, 'logic_a': 34, 'logic_b': 40, 'logic_c': 41}` mostly works but tempeature now has _undefined appended. With this change, instead of appending undefined, we just return the original proporty.

…eded

sjorge · 2022-10-02T14:58:39Z

Hitting a new problem:

Zigbee2MQTT:error 2022-10-02 16:54:50: Failed to configure '0x0015bc001a0238ec', attempt 1 (Error: Read 0x0015bc001a0238ec/34 msOccupancySensing(["develcoArmThresholdMinTemperature"], {"sendWhen":"active","timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"srcEndpoint":null,"reservedBits":0,"manufacturerCode":4117,"transactionSequenceNumber":null,"writeUndiv":false}) failed (Status 'UNSUPPORTED_ATTRIBUTE')
    at Endpoint.checkStatus (/opt/zigbee2mqtt/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:317:28)
    at Endpoint.read (/opt/zigbee2mqtt/node_modules/zigbee-herdsman/src/controller/model/endpoint.ts:480:22)
    at Object.configure (/Users/sjorge/Documents/repos/zigbee-herdsman-converters/devices/develco.js:593:17)
    at Configure.configure (/opt/zigbee2mqtt/lib/extension/configure.ts:115:13))

https://www.develcoproducts.com/media/1697/moszb-130-14x-technical-manual-motion-sensor-040721.pdf

https://github.com/Koenkk/zigbee-herdsman/blob/371a58547499e0acb5ec475549fb81c9d59ebcb3/src/zcl/definition/cluster.ts#L2560-L2562

I'm sure I added them correctly to herdsman, I also tried reading them without the manufactureCode set but same result as with it set.

Koenkk · 2022-10-03T20:06:34Z

It looks good indeed, but maybe we are missing something. Can you make a sniff of just the read request?

sjorge · 2022-10-04T07:04:13Z

It looks good indeed, but maybe we are missing something. Can you make a sniff of just the read request?

Sure, I'll try to grab it this week, busy week ahead so might be in the weekend.

sjorge · 2022-10-04T19:14:02Z

My development coordinator, so not the same key as my production one.

cc:7c:3d:c3:4d:66:28:11:53:dc:54:6c:db:9a:aa:07

This one is it joining without the reading the troublesome attributes:
join_moszb140.pcapng.zip

Here is a read to one of the troublesome attributes: (zbee_nwk.src == 0xad2f || zbee_nwk.dst == 0xad2f)
read_msOccupancySensing.develcoTargetLevel.zip

I did 2 reads, one with specifying the manufacturerCode and one without, I used 2 test converters for this so I can just share the exact code:

        test: {
            key: ['test'],
            convertSet: async (entity, key, value, meta) => {
            },
            convertGet: async (entity, key, meta) => {
                await entity.read('msOccupancySensing', ['develcoTargetLevel'], manufacturerOptions);
            },
        },
        test2: {
            key: ['test2'],
            convertSet: async (entity, key, value, meta) => {
            },
            convertGet: async (entity, key, meta) => {
                await entity.read('msOccupancySensing', ['develcoTargetLevel']);
            },
        },

Koenkk · 2022-10-05T14:53:05Z

Everything looks correct to me; the cluster 0x0406, manufcode 0x1015 and attribute 0xfc02. So it looks their docs are either not correct or maybe there are multiple revisions/fws for this device.

sjorge · 2022-10-05T16:17:52Z

Yeah, I’m assuming there docs are wrong.I’ll pull out a few general fixes from this into a separate PR and close this one, no need to add the other occupancies if they are just going to be the same except a different timeout.~ sjorgeOn 5 Oct 2022, at 16:53, Koen Kanters ***@***.***> wrote: Everything looks correct to me; the cluster 0x0406, manufcode 0x1015 and attribute 0xfc02. So it looks their docs are either not correct or maybe there are multiple revisions/fws for this device. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

There was a issue were configure kept failing due to timeouts on reading these. As show in Koenkk#4731 the tech manual might not be 100% accurate. So putting them in a try/catch should at least let the configuration continue settings up everything else.

sjorge · 2022-10-05T17:55:04Z

Closed in favor of #4741, will re-open if I do somehow end up hearing back from develco on this.

There was a issue were configure kept failing due to timeouts on reading these. As show in Koenkk#4731 the tech manual might not be 100% accurate. So putting them in a try/catch should at least let the configuration continue settings up everything else.

* utils: postfixWithEndpointName should handle "undefined" better e.g. the MOSZB-140 has 35 as the default endpoint, most of the config on genBasic, genPowerCfg and ssIasZone are there. Additionally it uses seperate endpoints for temperature and illumance (40 and 39). It also has 3 (!!) msOccupancySensing endpoints (34, 40, 41), for those we do want to provide a suffix to the property name. For those we don't really need a suffix for the propery name, having `{default: 35, 'logic_a': 34, 'logic_b': 40, 'logic_c': 41}` mostly works but tempeature now has _undefined appended. With this change, instead of appending undefined, we just return the original proporty. * MOSZB-140: cleanup - drop read of batteryVoltage, reporting configuration does this - update reporting settings to match with the suggestions from develco (esp illumantion was very spanny and battery draining with the defaults) * MOSZB-140: try/catch on read of develcoAlarmOffDelay/develcoLedControl There was a issue were configure kept failing due to timeouts on reading these. As show in #4731 the tech manual might not be 100% accurate. So putting them in a try/catch should at least let the configuration continue settings up everything else.

* utils: postfixWithEndpointName should handle "undefined" better e.g. the MOSZB-140 has 35 as the default endpoint, most of the config on genBasic, genPowerCfg and ssIasZone are there. Additionally it uses seperate endpoints for temperature and illumance (40 and 39). It also has 3 (!!) msOccupancySensing endpoints (34, 40, 41), for those we do want to provide a suffix to the property name. For those we don't really need a suffix for the propery name, having `{default: 35, 'logic_a': 34, 'logic_b': 40, 'logic_c': 41}` mostly works but tempeature now has _undefined appended. With this change, instead of appending undefined, we just return the original proporty. * MOSZB-140: cleanup - drop read of batteryVoltage, reporting configuration does this - update reporting settings to match with the suggestions from develco (esp illumantion was very spanny and battery draining with the defaults) * MOSZB-140: try/catch on read of develcoAlarmOffDelay/develcoLedControl There was a issue were configure kept failing due to timeouts on reading these. As show in Koenkk#4731 the tech manual might not be 100% accurate. So putting them in a try/catch should at least let the configuration continue settings up everything else.

sjorge added 4 commits September 30, 2022 21:39

fz: occupancy should use postfixWithEndpointName

ea93f7c

fz: occupancy_timeout should use postfixWithEndpointName

1aa6069

enable multiEndpoint and setup occupancy for all endpoints on MOSZB-140

4afbd11

This comment was marked as resolved.

Sign in to view

sjorge force-pushed the moszb140p3 branch from f449782 to 5a6cf1c Compare October 2, 2022 14:26

use wellknown ep names + have occupany_timeout convert redirect if ne…

7790e38

…eded

sjorge force-pushed the moszb140p3 branch from 5a6cf1c to 7790e38 Compare October 2, 2022 14:31

sjorge mentioned this pull request Oct 5, 2022

MOSZB-140 some minor cleanup and fixes #4741

Merged

sjorge closed this Oct 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MOSZB-140 : Add configurable occupancy endpoints #4731

MOSZB-140 : Add configurable occupancy endpoints #4731

sjorge commented Oct 2, 2022 •

edited

This comment was marked as resolved.

This comment was marked as resolved.

sjorge commented Oct 2, 2022

Koenkk commented Oct 3, 2022

sjorge commented Oct 4, 2022

sjorge commented Oct 4, 2022

Koenkk commented Oct 5, 2022

sjorge commented Oct 5, 2022 via email

sjorge commented Oct 5, 2022

MOSZB-140 : Add configurable occupancy endpoints #4731

MOSZB-140 : Add configurable occupancy endpoints #4731

Conversation

sjorge commented Oct 2, 2022 • edited

This comment was marked as resolved.

This comment was marked as resolved.

sjorge commented Oct 2, 2022

Koenkk commented Oct 3, 2022

sjorge commented Oct 4, 2022

sjorge commented Oct 4, 2022

Koenkk commented Oct 5, 2022

sjorge commented Oct 5, 2022 via email

sjorge commented Oct 5, 2022

sjorge commented Oct 2, 2022 •

edited