MOSZB-140 some minor cleanup and fixes #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. the MOSZB-140 has 35 as the default endpoint, most of the config on genBasic, genPowerCfg and ssIasZone are there.
Additionally it uses seperate endpoints for temperature and illumance (40 and 39). It also has 3 (!!) msOccupancySensing endpoints (34, 40, 41), for those we do want to provide a suffix to the property name.
For those we don't really need a suffix for the propery name, having `{default: 35, 'logic_a': 34, 'logic_b': 40, 'logic_c': 41}` mostly works but tempeature now has _undefined appended.
With this change, instead of appending undefined, we just return the original proporty.
- drop read of batteryVoltage, reporting configuration does this - update reporting settings to match with the suggestions from develco (esp illumantion was very spanny and battery draining with the defaults)
There was a issue were configure kept failing due to timeouts on reading these. As show in Koenkk#4731 the tech manual might not be 100% accurate. So putting them in a try/catch should at least let the configuration continue settings up everything else.
sjorge
force-pushed
the
moszb140cleanup
branch
from
5dd9651
to
12efb28
Compare
|
Thansk! |
|
I’ve said a reminder in 2 weeks to clean up the 2 attributes in herdsman it u don’t hear back from deveclo |
Mephistofeles
pushed a commit
to Mephistofeles/zigbee-herdsman-converters
that referenced
this pull request
Dec 13, 2022
* utils: postfixWithEndpointName should handle "undefined" better
e.g. the MOSZB-140 has 35 as the default endpoint, most of the config on genBasic, genPowerCfg and ssIasZone are there.
Additionally it uses seperate endpoints for temperature and illumance (40 and 39). It also has 3 (!!) msOccupancySensing endpoints (34, 40, 41), for those we do want to provide a suffix to the property name.
For those we don't really need a suffix for the propery name, having `{default: 35, 'logic_a': 34, 'logic_b': 40, 'logic_c': 41}` mostly works but tempeature now has _undefined appended.
With this change, instead of appending undefined, we just return the original proporty.
* MOSZB-140: cleanup
- drop read of batteryVoltage, reporting configuration does this
- update reporting settings to match with the suggestions from develco
(esp illumantion was very spanny and battery draining with the defaults)
* MOSZB-140: try/catch on read of develcoAlarmOffDelay/develcoLedControl
There was a issue were configure kept failing due to timeouts on reading these.
As show in Koenkk#4731 the tech manual might not be 100%
accurate. So putting them in a try/catch should at least let the configuration continue settings up everything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few bits pulled in from #4731 (comment)
I did fire off an e-mail to develco, but the last time I did that I got no answer from them, so I am not very hopeful. This PR cherry picks a few minor things from that one.
propertyname_undefinednow (was hitting this with the other PR, but still a good general improvement)Although i can't reproduce the issues myself, based on #4731 I have a bit less faith in the technical manual.