Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Busch-Jaeger devices #5299

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Fixes for Busch-Jaeger devices #5299

merged 5 commits into from
Jan 23, 2023

Commits on Jan 8, 2023

  1. Report BJ switches as lights and use proper endpoint definition

    The BJ ZLL switches/relays/dimmers are currently exposed as switches
    with a non-prefixed endpoint. This causes two issues:
    
    - Dimming is not working for the dimmer modules
    - Both `state` and `state_relay` is published as an attribute, where
      only `state_relay` makes sense here. However the Z2M UI and Home
      Assistant auto-discovery were both using the "wrong" attribute.
    
    This commit addresses both issues, but will cause some changes for
    existing users:
    
    - Home Assistant auto-discovery will change (device changes from switch
      to light)
    - All BJ ZLL devices will have a brightness attribute (and brightness
      slider in the Z2M web UI), even if they do not support dimming. This
      is due to the fact that all devices are reported as the same model
      and Z2M cannot distinguish them.
    - The top rocker (endpoint 10) will not be bound to the coordinator
      any more if the module was installed on a relay or dimmer. This is
      just a clean-up, which won't have a practical effect.
    klada committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    3a08431 View commit details
    Browse the repository at this point in the history
  2. Don't expose state for all Busch-Jaeger devices

    We don't need to expose all Busch-Jaeger devices as lights, but only the
    ones which are actually connected to a relay or dimmer.
    klada committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    8c0978c View commit details
    Browse the repository at this point in the history
  3. Do not drop scenes cluster from Busch-Jaeger RB01

    The scenes cluster workaround does not seem to be required for the
    battery-powered Busch-Jaeger wall switches.
    
    This will only affect freshly paired devices, existing devices will be
    kept es they are.
    klada committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    b1d257d View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Keep Busch-Jaeger lights exposed as switch as well for compat reasons

    The switch definition for these devices is actually wrong here, but
    let's keep it for compatibility reasons as it has been there first.
    klada committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    474b6ab View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Update busch-jaeger.js

    Koenkk authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ec9f361 View commit details
    Browse the repository at this point in the history