Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed fingerprints for all devices - all devices stopped working af… #5425

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

TheStigh
Copy link
Contributor

@TheStigh TheStigh commented Feb 1, 2023

Hi Koen - after the update to 1.30.0-1, all Datek devices stopped woring with unknown devices. As an urgent fix I removed all added fingerprints to all devices.

Can you make an emergency update as all Datek devices now are down?

@geirra
Copy link
Contributor

geirra commented Feb 2, 2023

Just looking at the commit here, is it correct to remove the ota and power on behaviorr of the apex smartplug?

@TheStigh
Copy link
Contributor Author

TheStigh commented Feb 2, 2023

@geirra Think we do this revert, then I'll go over and re-test and put back later this month. Important are getting devices back from unsupported in Z2M. I'm also on travel so little to spend time on this until after upcoming weekend.

@geirra
Copy link
Contributor

geirra commented Feb 2, 2023

Can atleast confirm the OTA updates for APEX smart plug 16A works, pushed from 2.1 firmware to 2.5 after modifying the config manually just to test it.

@owangen
Copy link
Contributor

owangen commented Feb 2, 2023

@TheStigh Will the Eva devices still work after you removed the fingerprints?

@TheStigh
Copy link
Contributor Author

TheStigh commented Feb 2, 2023

Can atleast confirm the OTA updates for APEX smart plug 16A works, pushed from 2.1 firmware to 2.5 after modifying the config manually just to test it.

I didn't remove the OTA in my PR? I used the latest device list from datek.js when removed the fingerprints. I can add OTA for APEX in this PR until @Koenkk merge it.

@TheStigh
Copy link
Contributor Author

TheStigh commented Feb 2, 2023

@TheStigh Will the Eva devices still work after you removed the fingerprints?

Not still - they will work again. Integration was broken introducing the fingerprint.
I will re-introduce fingerprint later but after good testing first.

@geirra
Copy link
Contributor

geirra commented Feb 2, 2023

Can atleast confirm the OTA updates for APEX smart plug 16A works, pushed from 2.1 firmware to 2.5 after modifying the config manually just to test it.

I didn't remove the OTA in my PR? I used the latest device list from datek.js when removed the fingerprints. I can add OTA for APEX in this PR until @Koenkk merge it.

Look at the diff, both OTA and power on behavior is removed with this commit.
Screenshot 2023-02-02 at 16 09 05

@TheStigh
Copy link
Contributor Author

TheStigh commented Feb 2, 2023

Can atleast confirm the OTA updates for APEX smart plug 16A works, pushed from 2.1 firmware to 2.5 after modifying the config manually just to test it.

I didn't remove the OTA in my PR? I used the latest device list from datek.js when removed the fingerprints. I can add OTA for APEX in this PR until @Koenkk merge it.

Look at the diff, both OTA and power on behavior is removed with this commit. Screenshot 2023-02-02 at 16 09 05

Added as part of this PR.

Beklager Geir - er på reise og ble hektisk fiks fra hotellet!

@Koenkk Koenkk merged commit d5058ce into Koenkk:master Feb 2, 2023
@Koenkk
Copy link
Owner

Koenkk commented Feb 2, 2023

Thanks!

@owangen
Copy link
Contributor

owangen commented Feb 2, 2023

@TheStigh Will the Eva devices still work after you removed the fingerprints?

Not still - they will work again. Integration was broken introducing the fingerprint. I will re-introduce fingerprint later but after good testing first.
@TheStigh EVA devices is whitelabel of the Datek devices right? If so you should consider using the whiteLabel property instead of fingerprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants