Add functionality to Xiaomi MCCGQ13LM #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to Xiaomi MCCGQ13LM (lumi.magnet.ac01). This devise have some kind of anti theft protection - battery cover position.
Add functionality to Xiaomi MCCGQ13LM (lumi.magnet.ac01). This devise have some kind of anti theft protection - battery cover position.
Koenkk
reviewed
Mar 18, 2023
lib/xiaomi.js
Outdated
| @@ -502,6 +502,11 @@ const numericAttributes2Payload = async (msg, meta, model, options, dataObject) | |||
| payload.buzzer_manual_alarm = value === 1; | |||
| } | |||
| break; | |||
| case '320': | |||
| if (['MCCGQ13LM'].includes(model.model)) { | |||
| payload.cover = {0: 'Close', 1: 'Open'}[value]; | |||
There was a problem hiding this comment.
Please rename this to battery_cover and make the values CLOSE/OPEN
There was a problem hiding this comment.
Done. Renamed to battery_cover and made the values CLOSE/OPEN
Koenkk
reviewed
Mar 18, 2023
devices/xiaomi.js
Outdated
| @@ -745,7 +745,9 @@ module.exports = [ | |||
| fromZigbee: [fz.xiaomi_contact, fz.ias_contact_alarm_1, fz.aqara_opple], | |||
| toZigbee: [], | |||
| meta: {battery: {voltageToPercentage: '3V_2850_3000'}}, | |||
| exposes: [e.contact(), e.battery(), e.battery_voltage()], | |||
| exposes: [e.contact(), e.battery(), e.battery_voltage(), | |||
| exposes.enum('battery_cover', ea.STATE, ['CLOSE', 'OPEN']).withDescription('Battery cover position'), | |||
There was a problem hiding this comment.
Sorry for not having noticed this on my first review. But this can become a binary:
exposes.binary('battery_cover', ea.STATE, 'OPEN', 'CLOSE')
There was a problem hiding this comment.
Done. Now it's binary.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to Xiaomi MCCGQ13LM (lumi.magnet.ac01). This devise have some kind of anti theft protection - battery cover position.