-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add status LED switch for WB-MSW-ZIGBEE v.4 and refactor to modern extend #7074
Conversation
Can you use the binary modern extend instead? This will also solve the issue you are currently having. Example: zigbee-herdsman-converters/src/lib/lumi.ts Line 1471 in 696ca35
|
Probably just generic binary? I'll try it UPD |
@Koenkk How to specify
Never mind, it looks like it accepts endpoint name string. |
Well, I must have done something wrong because now it does not work at all and reacts with errors on any action.
|
You need to remove the |
It worked, but now I want to finish refactoring it to modern extend. And for that I will need to make some fixes first. So I'm leaving this PR as a draft for now |
@Koenkk currently testing it as an external converter and it seems to be working well. However, I regularly get strange error in the logs, but can't seem to find the source of it. If I remove the sensor from Zigbee network, the flood of errors stops. |
It looks like the VOC is failing to bind and somehow all other binds are failing to show up in the GUI until I manually try to bind something else. The attribute reading fail is expected (mine doesn't have the sensor module installed), but this probably should now affect the bind this badly. In a stable version this error is missing. |
@Koenkk besides corrections, any ideas on described errors above? |
Could you provide the debug log of it?
The other binds are indeed not executed because of this, it stops when one of them fails. We should disabled the read for this attribute. |
@Koenkk I’ll see what I can capture
I suspect that this will happen with any combination of attributes if certain modules are not installed. What is the best way to handle this? |
Maybe we can add an option: |
@Koenkk This is what i caught with debug level + zigbee-herdsman debug log
|
Thanks! |
This PR was inspired by #7016. I'm trying to finish it's idea by properly exposing led control as a binary switch.
So far I was able to make a crude working prototype& However, it has hardcoded endpoint name and TS does not like the convertGet as
Promise<{ activity_indicator: unknown; }>
does not matchPromise<ConvertSetResult>
. I'll continue working on it but this muliEndpoint magic is kinda hard to understand and I would really appreciate the help.