feat: add status LED switch for WB-MSW-ZIGBEE v.4 and refactor to modern extend

[mrskycriper]

This PR was inspired by #7016. I'm trying to finish it's idea by properly exposing led control as a binary switch.

So far I was able to make a crude working prototype& However, it has hardcoded endpoint name and TS does not like the convertGet as Promise<{ activity_indicator: unknown; }> does not match Promise<ConvertSetResult>. I'll continue working on it but this muliEndpoint magic is kinda hard to understand and I would really appreciate the help.

[Koenkk]

Can you use the binary modern extend instead? This will also solve the issue you are currently having.

Example:

zigbee-herdsman-converters/src/lib/lumi.ts

Line 1471 in 696ca35

lumiLedIndicator: (args? :Partial<modernExtend.BinaryArgs>) => modernExtend.binary({

[mrskycriper]

lumiLedIndicator

Probably just generic binary? I'll try it

UPD
Ah, I see, it's an example

[mrskycriper]

@Koenkk How to specify entity_category for modern extends? I can't find any usage of withCategory() inside any of them.

Also, is it possible to specify the target endpoint? This device has two instances of genBinaryOutput. The one on 1st endpoint turns on Modbus and stops sending any data to Zigbee. The other is on the 5th, responsible for the LED indicator. I don't see any explicit endpoint configuration anywhere.

Never mind, it looks like it accepts endpoint name string.

[mrskycriper]

Well, I must have done something wrong because now it does not work at all and reacts with errors on any action.

Publish 'get' 'activity_indicator' to 'Bedroom Climate sensor' failed:
'Error: Read 0x04cd15fffe8fb6e9/5 genBinaryOutput([85], {
  "timeout":10000,
  "disableResponse":false,
  "disableRecovery":false,
  "disableDefaultResponse":true,
  "direction":0,
  "srcEndpoint":null,
  "reservedBits":0,
  "manufacturerCode":26214,
  "transactionSequenceNumber":null,
  "writeUndiv":false
}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'

Publish 'set' 'activity_indicator' to 'Bedroom Climate sensor' failed:
'Error: Write 0x04cd15fffe8fb6e9/5 genBinaryOutput({
  "85": {"value":1,"type":16}}, {
    "timeout":10000,
    "disableResponse":false,
    "disableRecovery":false,
    "disableDefaultResponse":true,
    "direction":0,
    "srcEndpoint":null,
    "reservedBits":0,
    "manufacturerCode":26214,
    "transactionSequenceNumber":null,
    "writeUndiv":false
}) failed (Status 'UNSUPPORTED_ATTRIBUTE')'

[Koenkk]

You need to remove the manufacturerCode (you also don't use it in activity_indicator)

[mrskycriper]

It worked, but now I want to finish refactoring it to modern extend. And for that I will need to make some fixes first. So I'm leaving this PR as a draft for now

[mrskycriper]

@Koenkk currently testing it as an external converter and it seems to be working well. However, I regularly get strange error in the logs, but can't seem to find the source of it.

If I remove the sensor from Zigbee network, the flood of errors stops.

[mrskycriper]

It looks like the VOC is failing to bind and somehow all other binds are failing to show up in the GUI until I manually try to bind something else. The attribute reading fail is expected (mine doesn't have the sensor module installed), but this probably should now affect the bind this badly. In a stable version this error is missing.

[mrskycriper]

@Koenkk besides corrections, any ideas on described errors above?

[Koenkk]

However, I regularly get strange error in the logs, but can't seem to find the source of it.

Could you provide the debug log of it?

The attribute reading fail is expected (mine doesn't have the sensor module installed), but this probably should now affect the bind this badly. In a stable version this error is missing.

The other binds are indeed not executed because of this, it stops when one of them fails. We should disabled the read for this attribute.

[mrskycriper]

Could you provide the debug log of it?

@Koenkk I’ll see what I can capture

The other binds are indeed not executed because of this, it stops when one of them fails. We should disabled the read for this attribute.

I suspect that this will happen with any combination of attributes if certain modules are not installed. What is the best way to handle this?

[Koenkk]

I suspect that this will happen with any combination of attributes if certain modules are not installed. What is the best way to handle this?

Maybe we can add an option: allowReadFail ?

[mrskycriper]

@Koenkk This is what i caught with debug level + zigbee-herdsman debug log

debug 2024-03-01 23:48:22 Received Zigbee message from 'Bedroom Climate sensor', type 'attributeReport', cluster 'msOccupancySensing', data '{"occupancy":0}' from endpoint 1 with groupID 0
error 2024-03-01 23:48:22 Exception while calling fromZigbee converter: Cannot read properties of undefined (reading 'endpointName')}
debug 2024-03-01 23:48:22 TypeError: Cannot read properties of undefined (reading 'endpointName') at Object.convert (/app/node_modules/zigbee-herdsman-converters/src/lib/modernExtend.ts:833:49) at Receive.onDeviceMessage (/app/lib/extension/receive.ts:153:51) at EventEmitter.wrappedCallback (/app/lib/eventBus.ts:174:23) at EventEmitter.emit (node:events:529:35) at EventBus.emitDeviceMessage (/app/lib/eventBus.ts:108:22) at Controller.<anonymous> (/app/lib/zigbee.ts:117:27)
info 2024-03-01 23:48:22 MQTT publish: topic 'zigbee2mqtt/Bedroom Climate sensor', payload '{"activity_led_indicator":false,"co2":616,"humidity":32.76,"illuminance":3874,"illuminance_lux":2,"last_seen":"2024-03-01T23:48:22+03:00","linkquality":123,"noise":30,"noise_detect_level":50,"noise_detected":false,"noise_timeout":60,"occupancy":false,"occupancy_level":13,"occupancy_sensitivity":50,"occupancy_timeout":60,"state_l1":"OFF","state_l2":"OFF","state_l3":"OFF","temperature":23.03,"temperature_offset":0,"th_heater":false,"update":{"installed_version":5,"latest_version":5,"state":"idle"},"voc":null}'

[mrskycriper]

@Koenkk created #7143 with the fix for this issue, so it can be merged before this PR

[Koenkk]

Thanks!