Failure for the Current_summation #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my point of view ther is a failure for the Current_summation. In the technical documentation, which i found here: http://docplayer.net/135845279-Technical-manual-for-zhemi101-zigbee-external-meter-interface-ha.html the range for the CurrentSummation is defined as 0x000000 - 0xFFFFFFF. This should be 0-268435455. And this makes much more sense as it is more realistic to set initial counter from the electricity meter. So the value of 1000 = 1,0 kWh 10.000 = 10,0 kWH and so on.
Koenkk
added a commit
to Koenkk/zigbee-herdsman-converters
that referenced
this pull request
Nov 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my point of view ther is a failure for the Current_summation. In the technical documentation, which i found here: http://docplayer.net/135845279-Technical-manual-for-zhemi101-zigbee-external-meter-interface-ha.html the range for the CurrentSummation is defined as 0x000000 - 0xFFFFFFF. This should be 0-268435455.
And this makes much more sense as it is more realistic to set initial counter from the electricity meter. So the value of 1000 = 1,0 kWh
10.000 = 10,0 kWH and so on.