Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability only partly published in version 1.3 #1395

Closed
didiht opened this issue Apr 9, 2019 · 2 comments
Closed

Availability only partly published in version 1.3 #1395

didiht opened this issue Apr 9, 2019 · 2 comments

Comments

@didiht
Copy link
Contributor

didiht commented Apr 9, 2019

After updating from version 1.2.1 to version 1.3 I observed that the availability state was published for only one router device.

I found the bug in the file lib/extension/deviceAvailability.js

After changing some code (see below) the availbility functionality works as expected again😄

raspi:/opt/zigbee2mqtt/lib/extension $ diff deviceAvailability.js deviceAvailability.js.v1.3
87,89c87
< //    setTimer(ieeeAddr) {
<     setTimer(device) {
<         const ieeeAddr = device.ieeeAddr;
---
>     setTimer(ieeeAddr) {
95,96c93
< //            this.handleInterval(ieeeAddr);
<             this.handleInterval(device);
---
>             this.handleInterval(ieeeAddr);

@Koenkk
Sorry, now I realized that this should be handled in Testing: device availability #775

@didiht didiht mentioned this issue Apr 9, 2019
7 tasks
Koenkk added a commit that referenced this issue Apr 9, 2019
@Koenkk
Copy link
Owner

Koenkk commented Apr 9, 2019

Thanks for reporting!

Can you check if this has been fixed in the latest dev branch?

@didiht
Copy link
Contributor Author

didiht commented Apr 10, 2019

@Koenkk You are welcome!

Reviewed and tested, works perfectly.

@didiht didiht closed this as completed Apr 10, 2019
Koenkk added a commit that referenced this issue Apr 16, 2019
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this issue Sep 26, 2019
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants