Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version numbers and hash #125

Merged
merged 4 commits into from
Jun 15, 2018
Merged

Add support for version numbers and hash #125

merged 4 commits into from
Jun 15, 2018

Conversation

ciotlosm
Copy link
Contributor

@ciotlosm ciotlosm commented Jun 15, 2018

Add support for version number on startup. Implements #119

  • Add version number from package
  • Add support to use latest hash
  • Documentation

@ciotlosm
Copy link
Contributor Author

Included documentation as well.

@Koenkk
Copy link
Owner

Koenkk commented Jun 15, 2018

I've refactored the code a bit, I think it's better to not have the user run a manual script (tag.sh) as people will forget to do this.

What do you think about this solution?

@ciotlosm
Copy link
Contributor Author

Looks good. My idea was to avoid embedding too much and extra things for the git commit as that will be used far less when going stable and versioned. Also has to work even if people don’t clone but use export to make repo size smaller.

Happy with both approaches as we get benefit anyway. Just make sure we don’t get too much size increase.

Sent with GitHawk

@Koenkk Koenkk merged commit c372618 into Koenkk:master Jun 15, 2018
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this pull request Sep 26, 2019
Add support for version numbers and hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants