Add Support for SwannOne Key Fob SWO-KEF1PA #1256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2019
Adding/removing from a group that is under a subtopic gives an error. Setting states to it work fine but not able to make any changes to it.
Koenkk
reviewed
Mar 15, 2019
| this.mqtt.subscribe(`${settings.get().mqtt.base_topic}/bridge/group/+/remove_all`); | ||
| this.mqtt.subscribe(`${settings.get().mqtt.base_topic}/bridge/group/+/+/remove_all`); |
There was a problem hiding this comment.
What is the reason for these changes?
|
I use the the syntax "group/GROUP_NAME" so I can subscribe to the group topic in Home Assistant for certain triggers. So, when I try to add/remove/remove_all devices using "zigbee2mqtt/group/group/GROUP_NAME/add" it doesn't work. I didn't realize this commit was included this pull request. Was going to open a new one. |
Koenkk
reviewed
Mar 15, 2019
| @@ -5,7 +5,7 @@ const utils = require('../util/utils'); | |||
| const dontCacheProperties = [ | |||
| 'action', 'button', 'button_left', 'button_right', 'click', 'forgotten', 'keyerror', | |||
| 'step_size', 'transition_time', 'action_color_temperature', 'action_color', | |||
| 'action_group', | |||
| 'action_group', 'armmode', 'panic', | |||
There was a problem hiding this comment.
This shouldn't be needed as the properties for this device are only action.
There was a problem hiding this comment.
You're right, I saw this after I had already updated my converter to delete armmode and replace it with action. I've updated it in on my end to take it out.
|
Closing this as device has been integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is also needed.
zigbee-shepherd-converters
qosmio/zigbee-herdsman-converters@636d942
qosmio/zigbee-herdsman-converters@e16ec72
AND
zigbee-shepherd
qosmio/zigbee-shepherd@84860c1
Will be creating pull requests for those as well.