Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce no floating promises. #22880

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Enforce no floating promises. #22880

merged 2 commits into from
Jun 4, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Jun 1, 2024 •
edited
Loading

Everything was "blindly" awaited to identify occurrences.

Also:

  • Adjusted lint max len to match zh/zhc
  • Global ignore for data folder contents

TODO:

  • Refactor occurrences where await really needs to be awaited properly (forEach & co).
  • void where await not needed.

@Nerivec Nerivec marked this pull request as ready for review June 4, 2024 18:03
@Koenkk Koenkk merged commit 2b8eaa1 into Koenkk:dev Jun 4, 2024
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jun 4, 2024

Thanks!

@Koenkk Koenkk mentioned this pull request Jun 4, 2024
Merged
@Nerivec Nerivec deleted the no-floating-promises branch June 4, 2024 18:06
@Nerivec Nerivec mentioned this pull request Jun 5, 2024
Merged
ghoz pushed a commit to ghoz/zigbee2mqtt that referenced this pull request Jun 14, 2024
@Nerivec @ghoz
fix: Enforce no floating promises (Koenkk#22880)
68567e9 
* Enforce no floating promises.

* forEach => for/of. Fix tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerivec @Koenkk