Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Availability code optimization/formatting #23065

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Availability code optimization/formatting #23065

merged 3 commits into from
Jun 16, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Jun 15, 2024

Supersedes #23061

  • Fix disabled device skip
  • Fix missing await
  • Add tests for better coverage
  • Cleanup existing tests (stuff copied/pasted, irrelevant to specific tests, a few more MQTT publish checks can probably be removed still)

CC: @ghoz

@Nerivec Nerivec requested a review from Koenkk June 15, 2024 02:30
@Koenkk
Copy link
Owner

Koenkk commented Jun 15, 2024

@ghoz can you check if this fixes #23061 ?

@ghoz
Copy link
Contributor

ghoz commented Jun 15, 2024

It does work as expected, thanks!

@ghoz ghoz mentioned this pull request Jun 15, 2024
Closed
@Koenkk Koenkk merged commit f574653 into Koenkk:dev Jun 16, 2024
11 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Jun 16, 2024

thanks!

@Koenkk Koenkk mentioned this pull request Jun 16, 2024
Merged
@Nerivec Nerivec deleted the availability-ext-cleanup branch June 16, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nerivec @Koenkk @ghoz