Do not ping disabled devices at start

[ghoz]

When devices have not been seen / not available at start, we ping them.
We should skip disabled devices, because they are well... disabled.

[ghoz]

the test

zigbee2mqtt/test/availability.test.js

Line 183 in eff341b

it('Should not ping disabled devices', async () => {

is not working corectly it seems.

when trying to add some logging to it,
The extensions starts 2 times, I guess on test start and when reset.
1st time all active devices with old timestamps are pinged, including the disabled ones
after resetExtension the timestamp has been updated so we don't ping it at start and the test passes

I tried changing the order of the reset extension and playing with the MQTT mock Clear, but I'm still not able to make the test fail even tough I do see the ping been called...
grumble.

[Nerivec]

I think the source of the issue may be around here rather:

zigbee2mqtt/lib/util/utils.ts

Line 264 in f184730

function isAvailabilityEnabledForEntity(entity: Device | Group, settings: Settings): boolean {

disabled looks to not be given a high enough priority in the various ifs, in some cases?

[Koenkk]

It should indeed be fixed in isAvailabilityEnabledForEntity

Can you try to move if (entity.isDevice() && entity.options.disabled) return false; to the top and see if that fixes your issue?

[ghoz]

superseded by #23065