Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore cache when re-interviewing device #23328

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix: Ignore cache when re-interviewing device #23328

merged 3 commits into from
Jul 12, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Jul 11, 2024

This PR fixes the following issues with re-interviewing:

  • When due to a re-interview the device fingerprint changes, the device definition is not reconsidered.
  • Properties like device manufacturerName and modelID are not updated. This is fixed by passing ignoreCache=true to device.interview()

Requires: Koenkk/zigbee-herdsman#1109

@Koenkk Koenkk requested a review from Nerivec July 11, 2024 20:04
@Koenkk Koenkk enabled auto-merge (squash) July 12, 2024 10:12
@Koenkk Koenkk merged commit e3fa0bf into dev Jul 12, 2024
21 checks passed
@Koenkk Koenkk deleted the fix/interview-ignore-cache branch July 12, 2024 10:15
@Koenkk Koenkk mentioned this pull request Jul 12, 2024
Merged
@Nerivec
Copy link
Collaborator

Nerivec commented Jul 12, 2024

Surprised this didn't require tweaking a few tests. Might be some hidden coverage issue?

Koenkk added a commit that referenced this pull request Jul 13, 2024
@Koenkk
fix(ignore): Update test cases for #23328
af7467b
@Koenkk
Copy link
Owner Author

Koenkk commented Jul 13, 2024

Good point, updated the test cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nerivec Nerivec Awaiting requested review from Nerivec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Koenkk @Nerivec