Add styling to graphviz devices and links #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
circo - graphviz version 2.40.1 (20161225.0304) => Warning: gvrender_set_style: unsupported style square - ignoring
|
|
Thanks! |
wilmardo
pushed a commit
to wilmardo/zigbee2mqtt
that referenced
this pull request
Sep 26, 2019
* Add styling to graphviz devices and links * Fix eslint error and gvrender_set_style warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add styling to distinguish types of devices in the graphviz map. The coordinator is shown with bold outline, routers have rounded edges and end devices have a dashed outline.
I also set dashed lines for links with lqi of 0.
I find these changes make it easier to interpret the graphviz map. Let me know if you like any or all of these changes.