Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for header extensions #65

Merged
merged 12 commits into from
May 4, 2018

Conversation

jonpas
Copy link
Contributor

@jonpas jonpas commented Feb 11, 2018

  • Close Add support for header extensions #64 Add support for PboPrefix.txt #43
  • Argument for header extensions (any in addition to prefix)
  • Write argument header extensions to PBO header on build
  • Read all header extensions (any in addition to prefix) from PBO header on unpack and inspect
  • Fix cat when multiple header extensions are present
  • Add argument header extension validation (required =)
  • Allow overwriting of prefix header extension read from $PBOPREFIX$ by argument header extension

@jonpas
Copy link
Contributor Author

jonpas commented Feb 12, 2018

Done. String operations could probably be improved, am open to suggestions.

Should we add a note when prefix is being overwritten? If so, is there a helper available like for error and warning?

@pixlcrashr
Copy link
Contributor

@jonpas @KoffeinFlummi Source built and run successful on Debian 9 machine.

@KoffeinFlummi KoffeinFlummi merged commit 4098de4 into KoffeinFlummi:master May 4, 2018
@jonpas jonpas deleted the headerExtensions branch May 4, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for header extensions
3 participants