Refactor AdvancedSettings; add example XML #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugwelle
force-pushed
the
advanced_settings
branch
2 times, most recently
from
0f41e29
to
af22dfe
Compare
- refactor "loadMappings" functions - recognize "*.mk3d" as a video file format - trim values of XML elements/attributes - clear mappings if the corresponding XML element exists - add an example advancedsettings.xml with all default values
bugwelle
force-pushed
the
advanced_settings
branch
from
af22dfe
to
6faf7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit message:
AdvancedSettings
This pull request refactors
AdvancedSettings.cpp. It removes redundant code and simplifies code regarding mappings. Also, tags are now trimmed and*.mk3dis added as a video format.Example
advancedsettings.xmlThis PR also adds an example xml file that is based on your version posted here. I added missing tags and changed the values to MediaElch's defaults.
I'm not exactly sure what
<forceCache>does. Could you explain that tag to me? 😄Changes
This PR has one change regarding the XML.
useFirstStudioOnlyis no longer an XML tag but instead an attribute of<studios>. This makes handling mappings easier as we only need one method for it. I also didn't find any documentation explaining that tag. The only website that mentions it is a post on https://www.kodinerds.net/.So I guess (?) this won't affect many users.