Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add EpisodeXmlWriter tests #775

Merged
merged 12 commits into from
Aug 17, 2019
Merged

[Test] Add EpisodeXmlWriter tests #775

merged 12 commits into from
Aug 17, 2019

Conversation

bugwelle
Copy link
Collaborator

@bugwelle bugwelle commented Aug 17, 2019

This PR adds further tests and fixes the NFO file generation of episodes.

@bugwelle bugwelle changed the title [Test] Add EpisodeXmlWriter [Test] Add EpisodeXmlWriter tests Aug 17, 2019
@codecov-io
Copy link

Codecov Report

Merging #775 into master will increase coverage by 0.93%.
The diff coverage is 53.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #775      +/-   ##
=========================================
+ Coverage    3.75%   4.69%   +0.93%     
=========================================
  Files         402     405       +3     
  Lines       33358   33451      +93     
=========================================
+ Hits         1254    1570     +316     
+ Misses      32104   31881     -223
Impacted Files Coverage Δ
src/media_centers/KodiXml.h 0% <ø> (ø) ⬆️
src/tv_shows/TvShowEpisode.h 50% <ø> (+50%) ⬆️
test/helpers/debug_output.h 50% <0%> (-50%) ⬇️
src/ui/tv_show/TvShowWidgetEpisode.cpp 0% <0%> (ø) ⬆️
src/ui/export/ExportDialog.cpp 0% <0%> (ø) ⬆️
src/data/Database.cpp 0% <0%> (ø) ⬆️
src/media_centers/KodiXml.cpp 7.39% <0%> (+0.6%) ⬆️
src/scrapers/tv_show/TheTvDb.cpp 0% <0%> (ø) ⬆️
src/media_centers/kodi/EpisodeXmlWriter.cpp 100% <100%> (ø)
test/unit/tv_shows/testTvShowFileSearcher.cpp 100% <100%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491519f...cb33087. Read the comment docs.

@bugwelle bugwelle merged commit b2af88e into Komet:master Aug 17, 2019
@bugwelle bugwelle deleted the episode branch August 17, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants