New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing breakpoint indicator #256

Closed
jcloggins opened this Issue May 6, 2015 · 15 comments

Comments

Projects
None yet
4 participants
@jcloggins

jcloggins commented May 6, 2015

When entering code that moves the location of a breakpoint, the breakpoint indicator cannot be removed from the view pane.

Example:

In file xyz.pl create a breakpoint at line n
Add a new line of code before line at which the breakpoint is located
Note that the breakpoint moves with the change in location of the line it references
Clear the breakpoint
Note that the editing pane still shows the breakpoint even though it no longer exists

@cgchoffman cgchoffman added the Type: Bug label May 6, 2015

@cgchoffman cgchoffman added this to the 9.1.1 milestone May 6, 2015

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented May 6, 2015

Please confirm what version of Komodo you're using: Help > About Komodo (Komodo > About Komodo on OSX)

@jcloggins

This comment has been minimized.

jcloggins commented May 6, 2015

Komodo IDE, version 9.0.1, build 87208, platform win32-x86.

Built on Thu Apr 16 11:54:31 2015.

Jesse C. Loggins

Embedded Software Engineer

UQM Technologies

4120 Specialty Place

Longmont CO 80504

(303) 682-4908

Fax: (303) 682-4901

For more company information, please visit us at www.UQM.com.

This email is intended solely for the person or entity to which it is addressed. Information contained and transmitted in this email may contain legally privileged, confidential and proprietary materials belonging to UQM Technologies, Inc. If you are not the intended recipient, you are notified that any review, dissemination, disclosure, printing, copying or other use of this email is strictly prohibited and you are requested to delete this email from any computer and notify the originator immediately.

From: Carey Hoffman [mailto:notifications@github.com]
Sent: Wednesday, May 06, 2015 11:36 AM
To: Komodo/KomodoEdit
Cc: jcloggins
Subject: Re: [KomodoEdit] Removing breakpoint indicator (#256)

Please confirm what version of Komodo you're using: Help > About Komodo (Komodo > About Komodo on OSX)


Reply to this email directly or view it on GitHub #256 (comment) . https://github.com/notifications/beacon/ALl7ll7S4SBYjZpt3fc7y2LFMqMijOMhks5oGkiYgaJpZM4ERY4H.gif

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 6, 2015

For performance considerations, we do not keep the breakpoint markers in the view in sync with our internal breakpoint list while there are unsaved changes. Once you save the document, resynchronization occurs and you will be able to remove the breakpoint that moved, the breakpoint list will update, etc.

We will keep this ticket open in our backlog, as there may be some room for improvement.

@mitchell-as mitchell-as modified the milestones: Backlog, 9.2 Jul 6, 2015

@jcloggins

This comment has been minimized.

jcloggins commented Jul 6, 2015

Quote: “Once you save the document, resynchronization occurs and you will be able to remove the breakpoint that moved, the breakpoint list will update, etc.”

I have done a little more experimenting with this issue and found that your statement is only correct up to a certain point.

If the breakpoint is cleared from the breakpoint list before the document is saved, the indicator does not resynk and cannot be cleared until the editor is closed and reopened. At which point the breakpoint reappears in the breakpoint list and can be completely cleared.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 4, 2015

This bad boy needs to get fixed. It's been around for a very long time.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 4, 2015

Yeah no kidding. Btw I think part of this bug is also that the breakpoint itself doesn't move, right?

If moving the breakpoint according to edits is too difficult I think an acceptable compromise would be to delete the breakpoint if the code around it is altered. Not ideal but definitely better than the current "solution".

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 4, 2015

No the breakpoint moves. If you set a breakpoint and add a line above it all the lines below that point + the breakpoint will move but you can't click on the breakpoint any more. Issue goes away if you save the buffer. The breakpoint becomes clickable.

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 4, 2015

I know the margin symbol moves, but does the actual breakpoint move? Does the debugger break on the line that the margin indicates?

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 4, 2015

Yes, it functions as expected once the file is saved.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 4, 2015

Does the debugger break on the line that the margin indicates?

I'm not sure @Naatan .

@jcloggins

This comment has been minimized.

jcloggins commented Nov 4, 2015

Note: The behavior is different between saving before starting a debug session and the save that occurs as the result of starting a debug session.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 4, 2015

Note: The behavior is different between saving before starting a debug session and the save that occurs as the result of starting a debug session.

Noted. In what way are they different?

@jcloggins

This comment has been minimized.

jcloggins commented Nov 4, 2015

If the save is before starting the session, everything behaves normally

If the save is the result of starting the debug session, the breakpoint occurs in the proper location - but the capability of deleting it is lost until Komodo is restarted.

Also note that I am using a Windows system.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 4, 2015

Thanks @jcloggins

@Naatan Naatan modified the milestones: 9.4, 10.0 Nov 13, 2015

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment