New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify: debug notification id only when calling hideNotification with… #2172

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
2 participants
@Defman21
Contributor

Defman21 commented Nov 21, 2016

… arguments

hideNotification could be called without arguments at all to hide all of them (for example, P_NOW notifications).

fixed #2120

Signed-off-by: Defman21 i@defman.me

Notify: debug notification id only when calling hideNotification with…
… arguments

Signed-off-by: Defman21 <i@defman.me>
@Naatan

This comment has been minimized.

Member

Naatan commented Nov 21, 2016

Perfect, thanks @Defman21 ! :)

@Naatan Naatan added this to the 10.2 milestone Nov 21, 2016

@Naatan Naatan self-assigned this Nov 21, 2016

@Naatan Naatan modified the milestones: 10.2.1, 10.2 Feb 22, 2017

@Naatan Naatan modified the milestones: 10.2.1, 10.2.2 Mar 14, 2017

@Naatan Naatan merged commit 38d5a3b into Komodo:master Apr 11, 2017

Naatan added a commit that referenced this pull request Apr 11, 2017

Notify: debug notification id only when calling hideNotification with…
… arguments - fixes #2120 (#2172)

Signed-off-by: Defman21 <i@defman.me>
rn=

@Defman21 Defman21 deleted the Defman21:fix-2120 branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment