Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): full store interface #172

Merged
merged 23 commits into from
Dec 3, 2019
Merged

feat(store): full store interface #172

merged 23 commits into from
Dec 3, 2019

Conversation

naezith
Copy link
Contributor

@naezith naezith commented Dec 2, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          33       33           
  Lines         749      749           
=======================================
  Hits          719      719           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7350c...7437081. Read the comment docs.

@todo
Copy link

todo bot commented Dec 3, 2019

Check if pending ended

// TODO: Check if pending ended
std::this_thread::sleep_for(2s);
return true;
}
void clear_pending(const int price) {


This comment was generated by todo based on a TODO comment in e123480 in #172. cc @KomodoPlatform.

@todo
Copy link

todo bot commented Dec 3, 2019

Set success correctly here

// TODO: Set success correctly here
success = true;
}
}
return success;
}


This comment was generated by todo based on a TODO comment in 9bd3c23 in #172. cc @KomodoPlatform.

@todo
Copy link

todo bot commented Dec 3, 2019

add a out parameter for error

//! TODO: add a out parameter for error
VLOG_F(loguru::Verbosity_ERROR, "mempool rpc call failed: {}", result.raw_result);
return true;
}


This comment was generated by todo based on a TODO comment in 9c9d0ad in #172. cc @KomodoPlatform.

@Milerius Milerius merged commit 9c3a097 into master Dec 3, 2019
@Milerius Milerius deleted the store branch December 3, 2019 17:00
@todo todo bot mentioned this pull request Dec 3, 2019
@todo todo bot mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants