Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] introduce semver #1681

Closed
wants to merge 1 commit into from
Closed

[docs] introduce semver #1681

wants to merge 1 commit into from

Conversation

ca333
Copy link

@ca333 ca333 commented Feb 26, 2023

No description provided.

@onur-ozkan
Copy link
Member

Upgrading to semantic versioning requires some more work, current versioning is done with MM_VERSION, and MM_DATETIME.

First, we need to get rid of those, and second we have to read version specified in the Cargo.toml file. And as last, we also need to fix version arg of mm2 commands. It's in the help guide, but it doesn't work. Will cover all of these in this week.

@@ -5,8 +5,9 @@

[package]
name = "mm2_main"
version = "0.1.0"
edition = "2018"
version = "1.0.0-beta"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mm2_bin_lib crate where we should set the version. Here is the complete upgrade to semantic versioning #1686

@ca333 ca333 closed this Mar 2, 2023
@ca333 ca333 deleted the init_semver branch April 26, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants