remove nomics and replace chart

[smk762]

Closes #2238

To test:

• check dex pro view chart. resize / maximise window. change pair. there should be no flicker or overflow.

We dont have i or this widget yet, though it uses tickers by default so it the ticker is supported a chart will display.
This has some known issues:

• The ticker may link to the wrong coin
  
• the ticker may not be supported
  

Until we can compile a list of correct/working tickers, I'll add an exclusion list for coins known to be no good. Please list any you encounter in this PR.

[cipig]

we could add a new file to https://github.com/KomodoPlatform/coins/tree/master/api_ids for livecoinwatch

• if there is an id for the coin, it takes that (useful for duplicate tickers like TRC for https://www.livecoinwatch.com/price/Terracoin-TRC and https://www.livecoinwatch.com/price/TRACERToken-_TRC... for the other one they use _TRC as ticker, which we can define like that in the file)
• if it's not set, it uses the ticker as is
• for the cases where the ticker is there but points to a wrong coin, we can use "" in the new api_ids file, to tell ADEX to not load a chart at all... https://www.livecoinwatch.com/price/McLarenF1FanToken-MCL would be such a candidate... it uses MCL, but is not Marmarachain

can we also please use 7d charts, instead of 1d? just set lcw-period="w"

[smk762]

can we also please use 7d charts, instead of 1d? just set lcw-period="w"

Done. I've not implemented an exclusion list yet, but will populate it from review feedback.

[cipig]

looks good, thanks
we need to remove the chain from the ticker though, eg -BEP20 and also -segwit because:

[cipig]

works fine now, thanks
this error shows up when i switch pairs, but looks like it has no negative effect, and idk if it's even related
[12:42:53] [error] [main.prerequisites.hpp:96] [304992]: Error: <svg> attribute viewBox: Unexpected end of attribute. Expected number, "".

[Canialon]

• looks like it can be a scrollbar if it is no chart, i guess it is not very good, will be nice to not cause it.

• in pair of fiat and not fiat coin: with some test coins, it is no data but with (screenshot 1) but with some test coins the chart displays with $ (screenshot 2)

-sometimes size broken

• the resizing looks weird and slow, also can just freeze with "loading data"

Screen.Recording.2023-04-05.at.15.02.13.mov

Screen.Recording.2023-04-05.at.15.06.33.mov

UPD: tested on MacOS

[cipig]

strange, i don't have those problems with the sidebar, the chart is not reloaded... the only thing is that everything is moved to the right, even if it doesn't fit into the window, like this:

btw, do we need this sidebar animation thingy? i guess it would make some things easier if we would simply disable the animation/resize of the sidebar

when i resize, the loading is indeed somewhat slow, but i don't care, i don't resize all the time
btw, saving the window size would be nice, then i wouldn't have to resize at all, see #2207

EDIT: the content is moved to the right instead of resized when i use the min width... if i make the windows bigger first and then hover the side bar, the part with the chart is resized and then it reloads here too

[endrilickollari]

Sidebar loading happening in Windows 10 also, sometimes it loads faster sometimes it gets stuck also during resizing it does the same thing.

Video:

AtomicDex.Desktop.test.chart.in.sidebar.mp4

Also when trying to trade test coins message appears:

OS: Windows 10
Resolution: 1920 x 1080

[smk762]

works fine now, thanks this error shows up when i switch pairs, but looks like it has no negative effect, and idk if it's even related [12:42:53] [error] [main.prerequisites.hpp:96] [304992]: Error: <svg> attribute viewBox: Unexpected end of attribute. Expected number, "".

This error is thrown from the widget's own script. It also comes up in the console on https://www.livecoinwatch.com/widgets

[smk762]

-sometimes size broken

• the resizing looks weird and slow, also can just freeze with "loading data"

Sidebar loading happening in Windows 10 also, sometimes it loads faster sometimes it gets stuck also during resizing it does the same thing.

I've now set it to use a fixed width, which should resolve the resizing issues.
Testcoins should also now be filtered out (if either ticker is a testcoin, there will be no chart)

[smk762]

Also when trying to trade test coins message appears:

This is expected, though I might tweak the wording, because yet implies there will be a chart in future (but for test coins this is unlikely)

[smk762]

Ready for re-review. You will have to reset assets config for the latest changes in coins repo (KomodoPlatform/coins#689) to apply

chart-update.mp4

[smk762]

It seems for some minor coins which are supported by livecoinwatch may not be supported as a pair. I can't think of a method to filter these out without using a pair exclusion list.

known-issue-1.mp4

As it is only affecting less common pairs, I'll make this an issue for future (so not a blocker for this PR)

[endrilickollari]

Chart looks very good now

video:

AtomicDex.Desktop.2023-04-06.19-56-39.mp4

OS: Windows 10

[Canialon]

looks good now:D