Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allowAnyOrigin to kong/manager.ingress [KM-122] #1078

Closed

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Jun 5, 2024

What this PR does / why we need it:

This pull request adds an optional property allowAnyOrigin under manager.ingress in kong Charts.

Which issue this PR fixes

KM-122

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@sumimakito sumimakito force-pushed the KM-122-kong-manager-allow-any-origin branch from 4366917 to 4981324 Compare June 5, 2024 07:38
@sumimakito sumimakito marked this pull request as ready for review June 5, 2024 07:39
@sumimakito sumimakito requested a review from a team as a code owner June 5, 2024 07:39
@sumimakito sumimakito changed the title feat: add allowAnyOrigin to kong/manager.ingress [KM-122] feat: add allowAnyOrigin to kong/manager.ingress [KM-122] Jun 5, 2024
@sumimakito sumimakito changed the title feat: add allowAnyOrigin to kong/manager.ingress [KM-122] feat: add allowAnyOrigin to kong/manager.ingress [KM-122] Jun 5, 2024
@@ -22,6 +22,9 @@
with non-KIC labels. Requires KIC 3.0+.
[#1061](https://github.com/Kong/charts/pull/1061)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this empty line.

@sumimakito sumimakito marked this pull request as draft June 5, 2024 08:00
@sumimakito
Copy link
Member Author

I've converted this PR into a draft as we need to be more considerate on this one. We probably also need to provide correct support for multiple URLs on the Gateway side.

cc @mheap

@mheap
Copy link
Member

mheap commented Jun 11, 2024

For completeness - setting allowed origins to * is something that Gateway allows, but I do not think we should allow via the chart as it is insecure. Instead, Gateway should support defining multiple hostnames

@sumimakito
Copy link
Member Author

Closing this PR as we decided it would be better to be a feature in Gateway instead of here.

@sumimakito sumimakito closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants