Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conf): add label configuration option when Kong is exposed via ingress #812

Merged
merged 1 commit into from
May 29, 2023

Conversation

bergemalm
Copy link
Contributor

What this PR does / why we need it:

Sometimes labels are used for filtering/configuring other resources. This PR adds support for adding custom labels to an ingress when Kong is exposed using an ingress controller.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@bergemalm bergemalm requested a review from a team as a code owner May 29, 2023 07:24
@CLAassistant
Copy link

CLAassistant commented May 29, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding this option to the README similarly how it's done for SVC.ingress.annotations?

charts/kong/CHANGELOG.md Outdated Show resolved Hide resolved
@bergemalm
Copy link
Contributor Author

Thanks! Do you mind adding this option to the README similarly how it's done for SVC.ingress.annotations?

I missed that one. Added! :)

@bergemalm
Copy link
Contributor Author

Merge at will @pmalek ? :)

@pmalek pmalek merged commit 295adee into Kong:main May 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants