Release consolidated chart as kong 3.0.0-rc1 #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
chore/release-kong-3-rc1
branch
from
27514ec
to
cdd7b5a
Compare
rainest
changed the title
mflendrich
previously approved these changes
Dec 19, 2023
There was a problem hiding this comment.
I approve this change with a big caveat: we understand that the 3.0 release must support various named use cases and this will take one of two forms, and we understand that the former is more likely
- differently named charts (kong/ingress, kong/konnect-dp, kong/operator, etc) with "batteries included" using default values.yaml
- same chart but with different values.yaml examples
Therefore
- I've asked that we remove the definitive language that might otherwise be forgotten to update before we reach a conclusive decision about the 3.0 shape
- we'll continue the march towards 3.0 in Next-gen (3.0) chart layout #977
Merged
rainest
force-pushed
the
chore/release-kong-3-rc1
branch
from
1c8ddc3
to
6d3608b
Compare
2 tasks
Copy pieces of the ingress chart Konnect example into the kong chart Konnect example.
Add migration notes for the ingress to kong 3.x change. Remove separate ingress templates and such.
Co-authored-by: Michał Flendrich <michal.flendrich@konghq.com>
rainest
force-pushed
the
chore/release-kong-3-rc1
branch
from
6d3608b
to
f2ddcbc
Compare
rainest
force-pushed
the
chore/release-kong-3-rc1
branch
from
58c6e63
to
1edf3f7
Compare
rainest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Releases the consolidated chart as kong 3.0.0-rc1.
Removes most existing
ingresschart content and consolidates someingressdocumentation into thekongfiles. Leaves a brief migration message and historical underingress.This will release an RC chart version from the release branch.
mainwill remain as-is for now. When we are ready to finalize the release, we will cut an old version release branch from the tip ofmainbefore merging this intomain.Special notes for your reviewer:
See the other PR. The name for the consolidated chart isn't particularly important, but since it is built from the
kongtemplates, releasing askongrequires much less trickery behind the scenes. There's also much less docs burden if existingkonglocations continue to exist.