Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): proper defaults for dump #1094

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix(cli): proper defaults for dump #1094

merged 1 commit into from
Nov 8, 2023

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 8, 2023

fixes this error; Error: output-file cannot be specified with --all-workspace flag

when using deck dump --all-workspaces.

@Tieske Tieske requested a review from a team November 8, 2023 12:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (b3ccdd5) 32.87% compared to head (0b26837) 32.87%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1094   +/-   ##
=======================================
  Coverage   32.87%   32.87%           
=======================================
  Files         103      103           
  Lines       12850    12847    -3     
=======================================
  Hits         4224     4224           
+ Misses       8217     8214    -3     
  Partials      409      409           
Files Coverage Δ
cmd/gateway_dump.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tieske Tieske merged commit bb4b840 into main Nov 8, 2023
35 checks passed
@Tieske Tieske deleted the fix/dump branch November 8, 2023 16:07
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants