feat: add proxy support for konnect #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
GGabriele
reviewed
May 30, 2023
|
@GGabriele instead of adding a custom option, shouldn't we just honor the OS env variables for proxies? just a thought |
|
e.g. use this function instead; https://pkg.go.dev/net/http#ProxyFromEnvironment |
|
replaced by #952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new parameter called "proxy-addr". This parameter is designed to help users who are trying to access Kong Konnect behind their company's network firewall. By specifying a proxy address, users can bypass the firewall and access Kong Konnect.
Example:
deck ping --proxy-addr http://proxy.example.com:8080