Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): honor the proxy environment variables #952

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jun 26, 2023

alternative to #890

@Tieske Tieske requested a review from a team as a code owner June 26, 2023 11:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (43ac0a8) 35.63% compared to head (3f18be3) 35.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   35.63%   35.63%   -0.01%     
==========================================
  Files          92       92              
  Lines       11342    11344       +2     
==========================================
  Hits         4042     4042              
- Misses       6907     6909       +2     
  Partials      393      393              
Impacted Files Coverage Δ
utils/types.go 14.70% <0.00%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GGabriele GGabriele merged commit 3555a9a into main Jul 3, 2023
33 checks passed
@GGabriele GGabriele deleted the feat/proxy branch July 3, 2023 13:33
zekth pushed a commit that referenced this pull request Jul 14, 2023
Co-authored-by: Gabriele Gerbino <gabrielegerbino@gmail.com>
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Co-authored-by: Gabriele Gerbino <gabrielegerbino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants