Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apiops): integrate go-apiops #939

Merged
merged 2 commits into from
Jul 14, 2023
Merged

feat(apiops): integrate go-apiops #939

merged 2 commits into from
Jul 14, 2023

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jun 12, 2023

replaces #912

Implements the following commands;

  • deck openapi2kong to convert an OAS 3.0 spec to a decK format
  • deck merge to merge multiple decK files into one (non-validating)
  • deck patch to update elements in a decK file (non-validating)

@Tieske Tieske requested a review from a team as a code owner June 12, 2023 09:34
@Tieske Tieske marked this pull request as draft June 12, 2023 09:38
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 0.51% and project coverage change: -1.58 ⚠️

Comparison is base (5bbd6a8) 35.63% compared to head (c4acd9a) 34.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
- Coverage   35.63%   34.05%   -1.58%     
==========================================
  Files          92      100       +8     
  Lines       11344    11879     +535     
==========================================
+ Hits         4042     4045       +3     
- Misses       6909     7441     +532     
  Partials      393      393              
Impacted Files Coverage Δ
cmd/addplugins.go 0.00% <0.00%> (ø)
cmd/addtags.go 0.00% <0.00%> (ø)
cmd/convert.go 0.00% <0.00%> (ø)
cmd/file.go 0.00% <0.00%> (ø)
cmd/listtags.go 0.00% <0.00%> (ø)
cmd/merge.go 0.00% <0.00%> (ø)
cmd/openapi2kong.go 0.00% <0.00%> (ø)
cmd/patch.go 0.00% <0.00%> (ø)
cmd/removetags.go 0.00% <0.00%> (ø)
cmd/root.go 0.91% <16.66%> (+0.91%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tieske Tieske changed the base branch from main to v2 June 12, 2023 13:58
@Tieske Tieske marked this pull request as ready for review June 12, 2023 14:22
@Tieske Tieske changed the base branch from v2 to beta/apiops June 22, 2023 15:33
@Tieske Tieske force-pushed the feat/apiops branch 2 times, most recently from 1127636 to b705f4f Compare June 22, 2023 15:43
@Tieske Tieske deleted the branch main June 26, 2023 11:25
@Tieske Tieske closed this Jun 26, 2023
@Tieske Tieske reopened this Jun 26, 2023
@Tieske Tieske changed the base branch from beta/apiops to main July 14, 2023 10:53
@Tieske Tieske added this to the 1.24.0 milestone Jul 14, 2023
@Tieske Tieske mentioned this pull request Jul 14, 2023
2 tasks
CHANGELOG_temp.md Outdated Show resolved Hide resolved
cmd/listtags.go Outdated Show resolved Hide resolved
cmd/patch.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@GGabriele
Copy link
Collaborator

Added a few minor comments and suggestions. On top of those, I noticed that new commands' descriptions are not always consistent: most of them use the third person (AddS, ListsS) while this is not done for penapi2kong Convert .... Also existing decK commands don't use the third person either.

For consistency, can we consolidate on not using the third person anywhere?

$ ./deck file
Sub-command to host the decK file manipulation operations.

Usage:
  deck file [command]

Available Commands:
  add-plugins  Adds plugins to objects in a decK file
  add-tags     Adds tags to objects in a decK file
  convert      Convert files from one format into another format
  list-tags    Lists current tags to objects in a decK file
  merge        Merges multiple decK files into one
  openapi2kong Convert OpenAPI files to Kong's decK format
  patch        Applies patches on top of a decK file
  remove-tags  Removes tags from objects in a decK file
  validate     Validate the state file

@Tieske Tieske force-pushed the feat/apiops branch 2 times, most recently from acd54b0 to c645154 Compare July 14, 2023 12:59
@Tieske Tieske merged commit 95bc95f into main Jul 14, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants