-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file): add render command #874
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
- Coverage 35.59% 35.52% -0.08%
==========================================
Files 92 92
Lines 11273 11309 +36
==========================================
+ Hits 4013 4017 +4
- Misses 6867 6897 +30
- Partials 393 395 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
convert/convert.go
Outdated
|
||
// convertDistributedToKong is used to convert one or many distributed format | ||
// files to create one Kong Gateway declarative config. It also leverages some | ||
// deck features like the defaults/centralized plugin configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add link to official Kong documentation here
@zekth it seems a test is failing due to some nil reference:
Would you mind checking? |
a99388b
to
1b238b4
Compare
As per internal discussion, this functionality is to land in its own command "render", which is to be a subcommand of the new "file" command. Since the "file" command is introduced in #939 , it makes sense to target that branch for now, instead of |
55b6b40
to
00b929b
Compare
closing in favour of #963 |
Proposal of a new format for
convert
command. Possible things to address: