Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render): add new command to render final file #963

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jul 14, 2023

recovers #874 including tests

@Tieske Tieske requested a review from a team July 14, 2023 15:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 31.33% and project coverage change: -0.12% ⚠️

Comparison is base (aee76dd) 34.06% compared to head (3516359) 33.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   34.06%   33.95%   -0.12%     
==========================================
  Files         100      101       +1     
  Lines       12106    12214     +108     
==========================================
+ Hits         4124     4147      +23     
- Misses       7588     7666      +78     
- Partials      394      401       +7     
Files Changed Coverage Δ
cmd/common.go 4.29% <0.00%> (ø)
cmd/common_konnect.go 6.71% <0.00%> (ø)
cmd/file.go 0.00% <ø> (ø)
cmd/file_convert.go 0.00% <0.00%> (ø)
cmd/file_render.go 0.00% <0.00%> (ø)
cmd/root.go 0.91% <0.00%> (-0.01%) ⬇️
cmd/validate.go 0.00% <0.00%> (ø)
file/writer.go 14.86% <23.52%> (+0.32%) ⬆️
file/readfile.go 73.15% <42.10%> (-12.22%) ⬇️
convert/convert.go 82.08% <56.81%> (-7.29%) ⬇️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/apiops to main July 14, 2023 16:11
@Tieske Tieske mentioned this pull request Jul 14, 2023
2 tasks
@Tieske Tieske added this to the 1.24.0 milestone Jul 14, 2023
Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR still need all the changes to the convert package now that an entire new command (render) has been added?

CHANGELOG.md Outdated Show resolved Hide resolved
@Tieske
Copy link
Member Author

Tieske commented Jul 17, 2023

Does this PR still need all the changes to the convert package now that an entire new command (render) has been added?

I removed the duplicate code from cmd/file_render.go, and left the changes in convert/convert.go. Reasoning; the convert package has tests, where the cmd package has not. So this seemed the better option.

cmd/file_render.go Outdated Show resolved Hide resolved
cmd/file_render.go Outdated Show resolved Hide resolved
@Tieske Tieske force-pushed the feat/render branch 2 times, most recently from 625abed to 57734db Compare July 17, 2023 13:45
@Tieske Tieske modified the milestones: 1.24.0, 1.25.0 Jul 18, 2023
@Tieske
Copy link
Member Author

Tieske commented Jul 18, 2023

moved this to the 1.25 milestone (was 1.24)

@Tieske Tieske force-pushed the feat/render branch 2 times, most recently from a0c7951 to 05e47cb Compare July 25, 2023 09:39
@Tieske
Copy link
Member Author

Tieske commented Jul 25, 2023

@GGabriele @zekth rebased and squashed. Should be ready to go now.

zekth
zekth previously approved these changes Jul 26, 2023
@Tieske Tieske merged commit d734514 into main Jul 27, 2023
35 checks passed
@Tieske Tieske deleted the feat/render branch July 27, 2023 14:34
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Co-authored-by: Vincent Le Goff <vincent.legoff@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants