Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct consumers handling when custom_id is used #986

Merged
merged 1 commit into from
Jul 28, 2023

Commits on Jul 27, 2023

  1. fix: correct consumers handling when custom_id is used

    Right now, when a consumer has the `username` equal to the
    `custom_id` of another consumer, decK fails because of the
    way the consumers are handled in the internal in-memory DB.
    
    ```
    _format_version: "3.0"
    consumers:
    - custom_id: foo
      id: ce49186d-7670-445d-a218-897631b29ada
      username: Foo
    - custom_id: bar
      id: 7820f383-7b77-4fcc-af7f-14ff3e256693
      username: foo
    ```
    
    ```
    $ deck sync
    Error: inserting consumer into state: inserting consumer Foo: entity already exists
    ```
    
    This commit fixes this defect by modifying the way consumers are
    looked up in the in-memory DB.
    GGabriele committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    32073a1 View commit details
    Browse the repository at this point in the history