fix: correct consumers handling when custom_id is used #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/consumers-username-custom_id
branch
from
2b81957
to
5743626
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 33.71% 33.68% -0.04%
==========================================
Files 100 100
Lines 12006 12018 +12
==========================================
Hits 4048 4048
- Misses 7564 7574 +10
- Partials 394 396 +2
☔ View full report in Codecov by Sentry. |
Right now, when a consumer has the `username` equal to the `custom_id` of another consumer, decK fails because of the way the consumers are handled in the internal in-memory DB. ``` _format_version: "3.0" consumers: - custom_id: foo id: ce49186d-7670-445d-a218-897631b29ada username: Foo - custom_id: bar id: 7820f383-7b77-4fcc-af7f-14ff3e256693 username: foo ``` ``` $ deck sync Error: inserting consumer into state: inserting consumer Foo: entity already exists ``` This commit fixes this defect by modifying the way consumers are looked up in the in-memory DB.
GGabriele
force-pushed
the
fix/consumers-username-custom_id
branch
from
5743626
to
32073a1
Compare
teb510
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when a consumer has the
usernameequal to thecustom_idof another consumer, decK fails because of the way the consumers are handled in the internal in-memory DB.This commit fixes this defect by modifying the way consumers are looked up in the in-memory DB.