[DOCU-2212] Zipkin: Document missing parameter default_service_name #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -54,6 +54,13 @@ params: | |||
| How often to sample requests that do not contain trace IDs. | |||
| Set to `0` to turn sampling off, or to `1` to sample **all** requests. The | |||
| value must be between zero (0) and one (1), inclusive. | |||
| - name: default_service_name | |||
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[kongplugins.Pluginspelling] Did you really mean 'default_service_name'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the missing parameter
default_service_name.This parameter was added in a pre-2.1 version, so we don't need to set any conditionals on it.
References:
Reason
https://konghq.atlassian.net/browse/DOCU-2212
Testing
Netlify