This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
feat(zipkin) override unknown-service-name #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bungle here is a single commit PR that is based upon latest master. |
bungle
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional configurable field to enable setting a defaulted service name in the zipkin spans to replace the unknown-service-name existing behaviour,
Fixes: #39
Fixes: #23 (I think if I am reading it correctly)
I defaulted the string to nil as to not change any behaviour of the plugin by default. Could easily set default to "Kong" if that is preferred but that would change default behaviour so I didn't commit it like that.