Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(kic): update prometheus labels for KIC 2.9.x #5146

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Feb 10, 2023

Description

Update prometheus labels for KIC 2.9.x to account for Kong/kubernetes-ingress-controller#3521

This also prunes some trailing whitespace in the changed doc.

Closes Kong/kubernetes-ingress-controller#3417

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@pmalek pmalek added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Feb 10, 2023
@pmalek pmalek requested a review from a team as a code owner February 10, 2023 14:08
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit f4192d4
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6407c8a9e576780008412f5e
😎 Deploy Preview https://deploy-preview-5146--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@acgoldsmith acgoldsmith self-assigned this Feb 10, 2023
@Guaris Guaris added this to the kic-2.9 milestone Feb 10, 2023
@pmalek pmalek added the Kubernetes Team Kubernetes task tracking (including KIC) label Mar 1, 2023
@pmalek
Copy link
Member Author

pmalek commented Mar 3, 2023

@acgoldsmith Can we get this merged? The conditional formatting allows us to merge this before KIC's 2.9 release

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar edits, otherwise LGTM. Merging them in directly since they don't change meaning.

@lena-larionova lena-larionova merged commit 4eff0a1 into main Mar 7, 2023
@lena-larionova lena-larionova deleted the kic-2.9.x-update-prometheus-metrics-labels branch March 7, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kubernetes Team Kubernetes task tracking (including KIC) review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigPush metrics in SCD mode should be labeled with dataplane's host
5 participants