-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dataplane metrics label #3521
Conversation
38e548c
to
5b5e0be
Compare
Codecov ReportBase: 72.4% // Head: 72.5% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
=======================================
+ Coverage 72.4% 72.5% +0.1%
=======================================
Files 120 121 +1
Lines 14318 14357 +39
=======================================
+ Hits 10369 10422 +53
+ Misses 3284 3274 -10
+ Partials 665 661 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9dbc558
to
9a400cf
Compare
5b5e0be
to
7c3e134
Compare
IMO we should be fine with adding the label and not adjusting it to the SCD in any special way. I think it's better to have it consistent across deployment modes. Note: we need to update https://docs.konghq.com/kubernetes-ingress-controller/latest/references/prometheus/. |
👍
Good catch, I'll add that to the related issue. |
What this PR does / why we need it:
This PR adds
dataplane
metrics label to account for KIC sending configuration to more than 1 gateway.The outcome of this PR will be that users will see separate time series for each dataplane for the following metrics:
ingress_controller_configuration_push_count
ingress_controller_configuration_push_duration_milliseconds
Which issue this PR fixes:
Fixes #3417
Special notes for your reviewer:
Blocked by #3421
This will make it so all
ingress_controller_configuration_push_count
andingress_controller_configuration_push_duration_milliseconds
time series will change. Regardless of running SCD or not. If we'd like to retain the current behaviour (not include the label) then we'd need to tweak this PR to account for this, i.e.:dataplane
label when running with 1 Gateway, communicating throughlocalhost
/127.0.0.1
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR