Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic: update and extend gRPC how-to #6567

Merged
merged 1 commit into from
Dec 4, 2023
Merged

kic: update and extend gRPC how-to #6567

merged 1 commit into from
Dec 4, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Nov 27, 2023 •
edited
Loading

Description

closes Kong/kubernetes-ingress-controller#5134

For HTTPRoute (support was added in Kong/kubernetes-ingress-controller#5128, so KIC >= 3.1.0 wii support it). For ingress, it works for older versions too

Testing instructions

Preview link: https://deploy-preview-6567--kongdocs.netlify.app/kubernetes-ingress-controller/latest/guides/services/grpc/

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@programmer04 programmer04 added the Kubernetes Team Kubernetes task tracking (including KIC) label Nov 27, 2023
@programmer04 programmer04 self-assigned this Nov 27, 2023
@programmer04 programmer04 marked this pull request as ready for review November 27, 2023 20:01
@programmer04 programmer04 added review:tech Request for technical review on the docs platform or processes. review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? labels Nov 27, 2023
@programmer04 programmer04 changed the title docs(kic): update gRPC how-to kic: update and extend gRPC how-to Nov 27, 2023
@programmer04 programmer04 marked this pull request as draft November 27, 2023 20:05
@programmer04 programmer04 requested a review from a team as a code owner November 27, 2023 20:16
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 5eb26c5
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/656e0c996dbf9d000847e1c5
😎 Deploy Preview https://deploy-preview-6567--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (🟢 up 2 from production)
Accessibility: 84 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@programmer04 programmer04 force-pushed the grpc-http branch 5 times, most recently from 5e50293 to 7d4c4ea Compare December 1, 2023 19:04
@mheap mheap marked this pull request as ready for review December 4, 2023 17:26
@mheap mheap self-requested a review December 4, 2023 17:26
@programmer04 programmer04 enabled auto-merge (squash) December 4, 2023 17:56
@programmer04 programmer04 merged commit 93b7ca3 into main Dec 4, 2023
15 checks passed
@programmer04 programmer04 deleted the grpc-http branch December 4, 2023 18:12
@programmer04 programmer04 mentioned this pull request Dec 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheap mheap mheap approved these changes

Assignees

@programmer04 programmer04

Labels
Kubernetes Team Kubernetes task tracking (including KIC) review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add info about gRPC without TLS (over HTTP) to gRPC how-to
2 participants
@programmer04 @mheap