Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore defaulting to protocol "grpcs" for gRPC Service #5283

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Dec 4, 2023

What this PR does / why we need it:

Heuristic introduced in #5128 for guessing whether for Kong Service grpc or grpcs protocol should be set breaks default behavior, that service without annotation for GRPCRoute is treated as grpcs.

Now documentation always mentions annotations for both grpc and grpcs see

Which issue this PR fixes:

Part of #4273

Special notes for your reviewer:

  • e0d56ea - modifies the test to show that the assumption about grpcs is indeed broken (the same setup as described in the docs before the update)
  • 6b2764b - contains actual fix (reverting heuristic introduced in fix: support GRPC with Gateway's HTTP listener #5128 - see getProtocolForKongService(...) and some small clean-ups and improvements

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added this to the KIC v3.1.x milestone Dec 4, 2023
@programmer04 programmer04 self-assigned this Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96941c3) 54.6% compared to head (db9f680) 75.5%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #5283      +/-   ##
========================================
+ Coverage   54.6%   75.5%   +20.9%     
========================================
  Files        169     170       +1     
  Lines      19264   19370     +106     
========================================
+ Hits       10530   14638    +4108     
+ Misses      7794    3903    -3891     
+ Partials     940     829     -111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 marked this pull request as ready for review December 4, 2023 18:42
@programmer04 programmer04 requested a review from a team as a code owner December 4, 2023 18:42
@programmer04 programmer04 enabled auto-merge (squash) December 4, 2023 18:42
@programmer04 programmer04 merged commit efca134 into main Dec 4, 2023
38 checks passed
@programmer04 programmer04 deleted the restore-default-grpcs branch December 4, 2023 19:22
@tao12345666333 tao12345666333 mentioned this pull request Apr 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants