-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kic): update rewrite-host guide with URLRewrite filter #7469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
czeslavo
force-pushed
the
rewrite-host-docs
branch
from
June 5, 2024 18:09
53d72b3
to
9671f15
Compare
czeslavo
added
the
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
label
Jun 5, 2024
czeslavo
force-pushed
the
rewrite-host-docs
branch
from
June 5, 2024 18:15
9671f15
to
e27ad76
Compare
czeslavo
force-pushed
the
rewrite-host-docs
branch
from
June 5, 2024 18:23
e27ad76
to
c19de85
Compare
pmalek
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than minor nit, this looks good.
app/_src/kubernetes-ingress-controller/guides/requests/rewrite-host.md
Outdated
Show resolved
Hide resolved
pmalek
reviewed
Jun 5, 2024
app/_src/kubernetes-ingress-controller/guides/requests/rewrite-host.md
Outdated
Show resolved
Hide resolved
pmalek
reviewed
Jun 5, 2024
…-host.md Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
czeslavo
force-pushed
the
rewrite-host-docs
branch
from
June 6, 2024 14:45
f31118d
to
b1561bd
Compare
mheap
reviewed
Jun 7, 2024
app/_src/kubernetes-ingress-controller/guides/requests/rewrite-host-and-paths.md
Outdated
Show resolved
Hide resolved
…-host-and-paths.md Co-authored-by: Michael Heap <m@michaelheap.com>
programmer04
approved these changes
Jun 7, 2024
mheap
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
team-k8s
Kubernetes task tracking (including KIC,KGO)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends
Rewrite Host
guide withURLRewrite
filter usage implemented in KIC 3.2.Closes Kong/kubernetes-ingress-controller#5853.
Testing instructions
Preview link:
Checklist