Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Re-Submitted] Added support for file extension filtering as well as ability to select a directory to file picker dialog #1131

Merged

Conversation

@nickhomme
Copy link
Contributor

nickhomme commented Aug 22, 2018

I've added support for the file input to have a file type filter applied as well as the ability to select directories if allowed.

Reasoning for this is to provide plugins the ability to have more complex capabilities such as looping through files in a directory or only allowing certain files to be selected.

Possible improvements would be to also allow option of multiple files to be selected.

nickhomme added 3 commits Aug 22, 2018
…v to pass in array of what types they want (file/directory)
@nickhomme

This comment has been minimized.

Copy link
Contributor Author

nickhomme commented Aug 22, 2018

Looks like my IDE performed some auto-formatting. Let me know if you'd like me to revert those formatting changes.

@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Aug 23, 2018

Thanks for the PR @nickhomme! Since it's such a small PR, the formatting stuff is fine. It's easy enough to find the meaningful code changes 😄 👍

@nickhomme

This comment has been minimized.

Copy link
Contributor Author

nickhomme commented Sep 12, 2018

@gschier
Is there something additional I need to do for the third check to run?

@gschier

This comment has been minimized.

Copy link
Contributor

gschier commented Sep 13, 2018

It's okay. Sometimes that last one doesn't run for some reason. Also, I haven't forgotten about this. Going to get it into the next release for sure!

@gschier
gschier approved these changes Nov 6, 2018
Copy link
Contributor

gschier left a comment

Looks awesome! Nice work 😄

@gschier gschier merged commit 4b1db75 into Kong:develop Nov 6, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 6, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

luizmariz pushed a commit to luizmariz/insomnia that referenced this pull request Jan 22, 2020
…ability to select a directory to file picker dialog (Kong#1131)

* Added file extensions filtering as well as ability to select directories to the file input picker.

* Removed redundant code using just one type 'file' and allowing the dev to pass in array of what types they want (file/directory)

* Fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.