Fixes #682: Support postman import schema v2.1.0 #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 To help make this a smooth process, please be sure you have first read the |
|
If this PR is considered OK I'd like to take a stab at adding support for importing some of the authentication parameters from Postman imports (both v2.0 and v2.1) |
|
Oh wow, it looks like not much changed between 2.0 and 2.1. Perhaps things were changed/added that we don't support yet? Either way, this looks awesome, thanks for doing it! 💯 |
|
And yes, please go ahead and extend support where needed. I'm sure A LOT of people will appreciate the improvements |
gschier
approved these changes
Oct 27, 2018
|
Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌 |
luizmariz
pushed a commit
to luizmariz/insomnia
that referenced
this pull request
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for postman import schema v2.1.0 to the same extent that v2.0.0 was supported. Most notably this means that authentication parameters still are not imported for either version.
Closes #682