Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty security object in openapi3 #2170

Merged
merged 3 commits into from
May 14, 2020

Conversation

develohpanda
Copy link
Contributor

Closes #2167, to handle the case where a security object under a path contains an empty item.

Also updates the import to show an error dialog before trying to extract workspaces, if there is a failure during import. This should give more informative error messages.

image

@develohpanda develohpanda self-assigned this May 14, 2020
@netlify
Copy link

netlify bot commented May 14, 2020

Deploy preview for insomnia-storybook ready!

Built with commit fac283b

https://deploy-preview-2170--insomnia-storybook.netlify.app

Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor comment

packages/insomnia-app/app/ui/redux/modules/global.js Outdated Show resolved Hide resolved
@develohpanda develohpanda merged commit 200c354 into develop May 14, 2020
@develohpanda develohpanda deleted the bug/handle-empty-security-object branch May 14, 2020 02:11
@nijikokun nijikokun added this to the 2020.1.4 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openapi3 spec with empty item in security schema fails to import
3 participants